HTS-1404: remove unnecessary ?page= from link #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajemaria
approved these changes
Dec 30, 2024
src/Geta.Optimizely.Tags/Areas/GetaOptimizelyTags/Pages/Index.cshtml.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private void SetItemPageNumber(IPagedList<Tag> items) |
Member
There was a problem hiding this comment.
if I read this correctly - "resaving" tags with correct page numbers will be done every time someone visits UI without page query string specified?
Contributor
Author
There was a problem hiding this comment.
Yes, the root cause of the issue is that the page number is reading default value of 1, so when it loads page it has to save it.
valdisiljuconoks
approved these changes
Jan 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getano.atlassian.net/browse/HTS-1404